Test /server-info endpoint in Dockerized environment

[jwodder]

Closes #977.

Blocked by dandi/dandi-archive#1108.

[codecov]

Codecov Report

Merging #1020 (3655aa1) into master (3655aa1) will not change coverage.
The diff coverage is n/a.

❗ Current head 3655aa1 differs from pull request most recent head 8a3d88f. Consider uploading reports for the commit 8a3d88f to get more accurate results

@@           Coverage Diff           @@
##           master    #1020   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          73       73           
  Lines        9291     9291           
=======================================
  Hits         8221     8221           
  Misses       1070     1070           

Flag	Coverage Δ
unittests	88.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3655aa1...8a3d88f. Read the comment docs.

[yarikoptic]

dandi/dandi-archive#1108 was addressed/closed -- should we retry this PR now @jwodder?

[jwodder]

@yarikoptic I'm still getting a 404 for http://localhost:8000/server-info. dandi/dandi-archive#1190 indicates that only /server-info/ (with a trailing slash) is currently accepted, yet the code relies on accessing the path without a trailing slash.

[yarikoptic]

note: I have followed up on dandi/dandi-archive#1108 (comment) .

I think that the path forward of the least resistance would be to switch to use /server-info/ with a trailing slash.

both main and staging support that

$> curl https://dandiarchive.org/server-info/
{"schema_version":"0.6.3","schema_url":"https://raw.githubusercontent.com/dandi/schema/master/releases/0.6.3/dandiset.json","version":"0.2.41","services":{"api":{"url":"https://api.dandiarchive.org/api"},"webui":{"url":"https://dandiarchive.org"},"jupyterhub":{"url":"https://hub.dandiarchive.org/"}},"cli-minimal-version":"0.14.2","cli-bad-versions":[]}%  

$> curl https://gui-staging.dandiarchive.org/server-info/
{"schema_version":"0.6.3","schema_url":"https://raw.githubusercontent.com/dandi/schema/master/releases/0.6.3/dandiset.json","version":"0.2.41","services":{"api":{"url":"https://api-staging.dandiarchive.org/api"},"webui":{"url":"https://gui-staging.dandiarchive.org"},"jupyterhub":{"url":"https://hub.dandiarchive.org/"}},"cli-minimal-version":"0.14.2","cli-bad-versions":[]}%      

or do you see any problem with that @jwodder ?

[jwodder]

@yarikoptic Would the Archive continue to support older versions of the CLI that use /server-info without a trailing slash?

[yarikoptic]

Well, ATM the actual deployment still has /server-info working through netlify somehow I guess. So unless and until that is changed, it would. Whenever it would stop we might need to boost minimal supported client version. For now I think it would be all good regardless.

[yarikoptic]

wouldn't this be made obsolete with #1298 @jwodder ?

[jwodder]

@yarikoptic No, get_instance() still makes requests to /server-info.

[yarikoptic]

@jwodder - please reapproach this PR to be finalized. It seems that trailing / is no longer needed:

❯ curl --silent https://dandiarchive.org/server-info
{"schema_version":"0.6.4","schema_url":"https://raw.githubusercontent.com/dandi/schema/master/releases/0.6.4/dandiset.json","version":"0.3.40","services":{"api":{"url":"https://api.dandiarchive.org/api"},"webui":{"url":"https://dandiarchive.org"},"jupyterhub":{"url":"https://hub.dandiarchive.org/"}},"cli-minimal-version":"0.51.0","cli-bad-versions":[]}

[jwodder]

@yarikoptic The Dockerized API instance currently returns 404 for http://localhost:8000/server-info with & without a trailing slash.

[yarikoptic]

@yarikoptic The Dockerized API instance currently returns 404 for http://localhost:8000/server-info with & without a trailing slash.

Please investigate why , check it with @AlmightyYakob et al.