Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a change in Git's behavior #46

Merged
merged 1 commit into from
May 21, 2024
Merged

Work around a change in Git's behavior #46

merged 1 commit into from
May 21, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 21, 2024

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (d0cab56) to head (02e2c9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   74.62%   74.77%   +0.14%     
==========================================
  Files          17       17              
  Lines        2735     2735              
  Branches      604      604              
==========================================
+ Hits         2041     2045       +4     
+ Misses        528      526       -2     
+ Partials      166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder merged commit 0feac63 into main May 21, 2024
7 checks passed
@jwodder jwodder deleted the unzulu branch May 21, 2024 16:58
@yarikoptic
Copy link
Member

this is unrelated to

@jwodder
Copy link
Member Author

jwodder commented May 21, 2024

@yarikoptic Completely unrelated. This is about timestamps emitted by Git; that issue is about timestamps emitted by Dandi Archive.

@yarikoptic
Copy link
Member

interesting... just odd that we are going the opposite directions here whenever in

@jwodder
Copy link
Member Author

jwodder commented May 21, 2024

@yarikoptic I opted for +00:00 here because that's the format used by Python's datetime.isoformat() method, while Z seems to be produced by Pydantic 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants