-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass --raw
or --raw-except=datalad
to addurl
#34
Conversation
The tests are currently failing because neurodebian's git-annex-standalone is still on version 10.20231227. |
now should be |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 74.77% 74.05% -0.72%
==========================================
Files 17 17
Lines 2735 2787 +52
Branches 604 615 +11
==========================================
+ Hits 2045 2064 +19
- Misses 526 554 +28
- Partials 164 169 +5 ☔ View full report in Codecov by Sentry. |
@yarikoptic Tests pass now. Can this be merged now? |
to merge we need to ensure that recent enough git-annex is within that env: dandi@drogon:/mnt/backup/dandi/dandisets$ source ~/.bashrc-miniconda
(base) dandi@drogon:/mnt/backup/dandi/dandisets$ conda activate dandisets-2
(dandisets-2) dandi@drogon:/mnt/backup/dandi/dandisets$ git-annex version
git-annex version: 10.20230126-g36f5557
...
(dandisets-2) dandi@drogon:/mnt/backup/dandi/dandisets$ which git-annex
/home/dandi/miniconda3/envs/dandisets-2/bin/git-annex but most recent annex is not on conda-forge due to problems building that ghc etc any clues on how to progress that one forward? (alternative would be to remove conda installation of git-annex and rely on neurodebian one, but it would be slower since standalone build) |
note: meanwhile upgraded system wide git-annex-standalone installation |
@yarikoptic Does drogon have a recent enough version of |
@yarikoptic Ping. |
yes, we have git-annex upgraded systemwide and I removed its installation from conda-forge's environment:
|
Tests are failing because the Archive hasn't updated to the new dandischema: dandi/dandi-archive#1975 |
@yarikoptic Tests are passing now. Can this finally be merged? |
def check_git_annex_version() -> None: | ||
# Call this function at the start of subcommand functions rather than in | ||
# `main()` so that it doesn't run if a user does `backups2datalad | ||
# subcommand --help` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet there should be a way for a common to all subcommands CLI context handling outside of --help, or may be in the top level context handling to do it is there is no --version or --help
But ok for now to get us going
Thank you! I left a comment but let's proceed |
Closes #26.