added a second parameter to the logic that checks the error that is retu... #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !(response[:status] == "failure" && (response[:error][:code] == "RECORD_NOT_FOUND" || response[:error][:code] == "LIST_NOT_FOUND")) | ||
| end | ||
|
|
||
| def list_exists?(list) |
There was a problem hiding this comment.
I wouldn't let this method in the code if it's not used.
|
Hey! Correct, that's a case that was not covered. I'm curious what was the error you had before this fix? Added a few comments, I'll give another look after you go over them. Also if you could add tests that would be awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rned from responsys
This was causing some errors and @HannahLehman worked HOURS to try and resolve it. A little digging later we discovered the response was checking for the wrong value. Not wanting to break any existing functionality, I added a second check on the new value being returned.
👍