-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this crate still maintained? #90
Comments
Hi @danburkert! I was just perusing through various repositories involving implementations of memory-mapping in Rust, and, in the process, I happened to come across both this issue and rbranson/rust-mmap#5, which made me smile. 😁 Are you still planning on handling the open issues and PRs? Just a friendly ping! 🏓 |
Since this crate has been flagged as unmaintained by RustSec, depending on it will fail builds for If the maintainer(s) of this crate would like some community support, I'd be happy to volunteer. I appreciate the work already invested in it. (cc @BurntSushi, who appears to be a co-maintainer) |
@RazrFalcon started a fork and released it on crates.io as memmap2, might also be a good option. |
@ranweiler My fork is maintained, but it doesn't really have any major changes. |
Thanks, @djc and @RazrFalcon. As a courtesy, I'd like to give this crate's maintainer(s) time to respond. That said, IMO it's important for the community to have a nice wrapper around memory mapping. If there's no update in say, a week, or if this crate is explicitly abandoned, my offer extends to |
I asked @danburkert a while back for commit access with the intent to try and pick up the maintenance for this crate. He graciously gave it to me, but sadly, I just haven't had the time to commit to it. So I wouldn't consider myself a co-maintainer at this point, and defer to @danburkert for whether to add new maintainers or not. (For my projects, I generally just prefer for someone to fork and carry it forward that way.) |
Understood, thanks for the update @BurntSushi! |
There's also mapr forked by Filecoin. I wonder whether they will be willing to maintain that crate @dignifiedquire? |
@RazrFalcon if you are willing to maintain memmap2 do you mind to copy current issues? |
@niamster Patches are welcome, but I don't plan on implementing them myself in the near feature. |
This replaces the unmaintained memmap crate with the memmap2 crate in order to fix the recurring security issue. In order to get a new and shiny build with the updated dependency, we have to bump the patch version of the package. Some details here: danburkert/memmap-rs#90
memmap is replaced by memmap2, because is unmaintained, see danburkert/memmap-rs#90.
Shouldn't this repository be archived and pointing to memmap2 in the readme? |
The former appears to be unmaintained: danburkert/memmap-rs#90
The former appears to be unmaintained: danburkert/memmap-rs#90
The former appears to be unmaintained: danburkert/memmap-rs#90
The former appears to be unmaintained: danburkert/memmap-rs#90
It seems like this crate wasn't really (well?) maintained since October 2018.
Last commit was 3b047cc (18 Apr 2018) and last release was memmap v0.7.0 (20 Sep 2018).
The text was updated successfully, but these errors were encountered: