Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace memmap crate since it is unmaintained #119

Closed
yangby-cryptape opened this issue Dec 2, 2020 · 1 comment · Fixed by #120
Closed

Replace memmap crate since it is unmaintained #119

yangby-cryptape opened this issue Dec 2, 2020 · 1 comment · Fixed by #120
Assignees
@mohanson

Comments

@yangby-cryptape
Copy link
Contributor

ckb-vm/Cargo.toml

Line 28 in 99276b2

memmap = "0.7.0"

The crates mapr or memmap2 may be reasonable alternatives.

References
@yangby-cryptape yangby-cryptape mentioned this issue Dec 2, 2020
Merged
bors bot added a commit to nervosnetwork/ckb that referenced this issue Dec 3, 2020
@bors @yangby-cryptape
Merge #2387
6ce716a 
2387: ci: skip RUSTSEC-2020-0077 temporarily r=quake,driftluo a=yangby-cryptape

Could be fixed after  [CKB-VM Issue-119: Replace `memmap` crate since it is unmaintained](nervosnetwork/ckb-vm#119) fixed.

Co-authored-by: Boyu Yang <[email protected]>
@mohanson
Copy link
Collaborator

mohanson commented Dec 3, 2020

mapr and memmap2 seem to only fork the upstream code, so either one is ok. I will submit a pr later.

@mohanson mohanson mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanson mohanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dependency: use mapr instead of memmap mohanson/ckb-vm
2 participants
@mohanson @yangby-cryptape