Android Configure Player Types and Markers #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by the LoopBuilder when the loop is first built. Automated players will have an implementation for this, so they will start the game once the loop has been built.
This introduces the MultiPlayerHumanTurn which will not advance the game loop like a SinglePlayerHumanTurn will.
This allows the UI to be refreshed upon each state transition.
This factory is responsible for wiring up the different Turns to the Loop based on the the player type
The preset is sent in the intent from the form in the previous activity.
| private static final String HUMAN_VS_COMPUTER = "human-vs-computer"; | ||
| private static final String HUMAN_VS_HUMAN = "human-vs-human"; | ||
|
|
||
| public static LoopBuilder presetFor(String preset) { |
There was a problem hiding this comment.
preset is sort of a weird name as an argument here, and maybe even for the class in general - is there a more focused name you can think of that reflects the specific thing that you're pre-setting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for a player to choose the player type, and the marker of the player.
To do this, I reworked the
Loopand created multiple newTurns which may or may not advance the loop.For now, a Computer vs. Computer is not allowed.