Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add automatic docs with pkgdown #8

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

jvfe
Copy link
Member

@jvfe jvfe commented Oct 1, 2024

  • chore: Add to ignore files

  • docs: Add basic DESCRIPTION slots

  • feat: Add pkgdown config

  • fix: Separate function and package doc

  • Addresses discussion in Nonpriority roadmap #5 (comment)

jvfe added 4 commits October 1, 2024 17:49
If this is not done, the reference index breaks and pkgdown can't find
the package's functions (in this case, function).
@jvfe jvfe added the documentation Improvements or additions to documentation label Oct 1, 2024
@jvfe jvfe requested a review from daniloimparato October 1, 2024 23:43
jvfe added 2 commits October 1, 2024 20:54
* main:
  docs: readme hex logo
  refactor: splits main logic into multiple steps and introduces caching
@daniloimparato
Copy link
Member

daniloimparato commented Oct 2, 2024

@jvfe thank you very much. I am not entirely familiar with pkgdown deployment. Is it ready for merging? Looks good to me.

image

@jvfe
Copy link
Member Author

jvfe commented Oct 2, 2024

@jvfe thank you very much. I am not entirely familiar with pkgdown deployment. Is it ready for merging? Looks good to me.

Should be, yes. The setup is really simple and I've already added a GH action that should build and deploy the website after every push.

@daniloimparato daniloimparato merged commit 205a395 into main Oct 2, 2024
2 checks passed
Copy link
Member

@daniloimparato daniloimparato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lol

@jvfe jvfe deleted the add-pkgdown branch October 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants