Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Remaining Time" sensor and add "Next State Change" timestamp sensor. #80

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

dalinicus
Copy link
Owner

  • Adds Remaining Time Port Property Sensor
  • Breaking Change: Remove Surplus Port Setting Sensor
    • This is a non-editable field in the settings payload, which we used as a property. The correct property was identified in the port properties payload, which replaces this sensor.
    • This sensor was not previously documented
  • Adds custom Next State Change sensor, which is a custom calculated sensor that uses the "remaining_time" field and the controllers configured timezone to express the datetime of the next state change caused by schedule and countdown based sensors

resolves #77

- calculated based on the controllers configured timezone
- fixed remaining_time control to use the proper property value instead of the surplus setting value
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b7b0fd0) to head (9210bd7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1081      1084    +3     
=========================================
+ Hits          1081      1084    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalinicus dalinicus changed the title Feature/next state change Fix "Remaining Time" sensor and add "Next State Change" timestamp sensor. Oct 21, 2024
@dalinicus dalinicus merged commit b259f46 into main Oct 21, 2024
13 checks passed
@dalinicus dalinicus deleted the feature/next-state-change branch October 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change/Add duration for timers to support progress
1 participant