Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for verify_batch #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Failing test for verify_batch #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c425f8b
propose failing test
NikVolf Feb 22, 2020
3769166
add to travis
NikVolf Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ matrix:

script:
- cargo $TEST_COMMAND --features="$FEATURES" $EXTRA_FLAGS
- cargo test --features=batch

notifications:
slack:
Expand Down
15 changes: 15 additions & 0 deletions src/batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,18 @@ pub fn verify_batch(
Err(SignatureError(InternalError::VerifyError))
}
}

#[test]
fn verify_batch_not_flaky_on_empty_input() {
for _ in 0..100 {
match
verify_batch(
&[&[]],
&[Signature::from_bytes(&[0u8; 64]).unwrap()],
&[PublicKey::from_bytes(&[0u8; 32]).unwrap()],
) {
Ok(_) => panic!("Successfully verified empty message with empty signature and empty public"),
Err(_) => continue,
}
}
}