Set non-enumerable for Object.prototype.clone() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pacman.js" can't mix up w/ other scripts which rely on [`for...in`](https://developer.Mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in) or [**Object.keys()**](https://developer.Mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys) but don't check for [**hasOwnProperty()**](https://developer.Mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty). Any inclusions for built-in native objects should be accompanied by [**Object.defineProperty()**](https://developer.Mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty) and have its new method set to `{ enumerable: false }`!
|
You're a legend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pacman.js" can't mix up w/ other scripts which rely on
for...inor Object.keys() but don't check for hasOwnProperty().Any inclusions for built-in native objects should be accompanied by Object.defineProperty() and have its new method set to
{ enumerable: false }!Here's the forum thread which has inspired this fix: :D
https://forum.Processing.org/two/discussion/13501/p5-js-crash-when-including-a-new-js-file-packman-js-in-the-same-html-file