terse decision on return value

daixtrose · Oct 23, 2024 · a66fd93 · a66fd93
1 parent a9b012f
commit a66fd93
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/polymorphism/test/include/test_polymorphism/mocking.hpp b/polymorphism/test/include/test_polymorphism/mocking.hpp
@@ -15,11 +15,9 @@ struct Mock {
     {
         ++numberOfCallsToCoolFeature;
 
-        if (0 != collectedSetArguments.size()) {
-            return collectedSetArguments.back();
-        } else {
-            return "<default value>";
-        }
+        return collectedSetArguments.empty()
+            ? "<default value>"
+            : collectedSetArguments.back();
     }
 
     void set(std::string s)
@@ -30,4 +28,4 @@ struct Mock {
 
 } // namespace mocking
 
-#endif // POYMORPHISM_MOCKING_HPP
+#endif // POLYMORPHISM_MOCKING_HPP