Merge pull request #50 from tape-tv/handle-empty-tracking-urls

don't try to resolve invalid urls
dailymotion · Sep 11, 2014 · 4980d00 · 4980d00
2 parents 2586dfc + 625e24a
commit 4980d00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/util.coffee b/src/util.coffee
@@ -18,6 +18,7 @@ class VASTUtil
 
         for URLTemplate in URLTemplates
             resolveURL = URLTemplate
+            continue unless resolveURL
             for key, value of variables
                 macro1 = "[#{key}]"
                 macro2 = "%%#{key}%%"

diff --git a/test/util.coffee b/test/util.coffee
@@ -20,3 +20,6 @@ describe 'VASTUtil', ->
 
         it 'should resolve weird cases', ->
             resolve("http://test.com/%%CONTENTPLAYHEAD%%&[CONTENTPLAYHEAD]", CONTENTPLAYHEAD: 120).should.equal "http://test.com/120&120"
+
+        it 'should handle undefined', ->
+            should(resolve(undefined)).equal undefined