Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydration issue on bookmarks list #4102

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: hydration issue on bookmarks list #4102

merged 2 commits into from
Jan 23, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 23, 2025

Changes

  • The issue is, a Plus user for some reason is having UI rendered wrongly for bookmarks list. One thing is for sure, I notice the margins on the header are not right, and that only happens locally when there is a hydration issue. We are trying to pinpoint the root cause by fixing anything that could be affecting the result. The problem is, no one is able to replicate the issue.
  • Previously, we tried using useViewSizeClient and it worked perfectly. The only issue is that, it produced a layout shift on the Feed on mobile.
  • Due to the urgency of the issue at hand, I've decided to go for this at the moment rather than jumping in the useFeedLayout rabbit hole (where we previously applied the useViewSizeClient).

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-bookmarks-list.preview.app.daily.dev

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 23, 2025 3:17pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 23, 2025 3:17pm

@sshanzel
Copy link
Member Author

Although the root cause of the issue has been fixed now, I am still motivated to have this hydration issue merged. Feel free to let me know if you think it is worth to go through the useFeedLayout still and fix everything or we can settle for this in the meantime.

@sshanzel sshanzel merged commit 70172d4 into main Jan 23, 2025
10 checks passed
@sshanzel sshanzel deleted the fix-bookmarks-list branch January 23, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants