Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support plus unavailable #4101

Merged
merged 7 commits into from
Jan 24, 2025
Merged

feat: support plus unavailable #4101

merged 7 commits into from
Jan 24, 2025
+191 −11

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Jan 23, 2025 •
edited
Loading

Changes

  • also includes case where user is plus already

(I know icon is wrong in screenshots, it was fixed)

Desktop:
image

Mobile:
image

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

AS-950

Preview domain

https://as-950-plus-unavailable.preview.app.daily.dev

@capJavert capJavert self-assigned this Jan 23, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 24, 2025 11:44am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 24, 2025 11:44am

@capJavert capJavert force-pushed the AS-950-plus-unavailable branch from c1698b3 to f5a232e Compare January 23, 2025 14:05
@capJavert capJavert force-pushed the AS-950-plus-unavailable branch from 1af51f3 to f5a232e Compare January 23, 2025 14:14
@capJavert capJavert marked this pull request as ready for review January 23, 2025 14:14
@capJavert capJavert requested a review from a team as a code owner January 23, 2025 14:14
@capJavert capJavert mentioned this pull request Jan 23, 2025
Merged
sshanzel
sshanzel approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much experience with Paddle and changing the pricing ids, if there is nothing to be worried about, everything looks amazing.

rebelchris
rebelchris approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D

@capJavert capJavert merged commit 883f4c9 into main Jan 24, 2025
10 checks passed
@capJavert capJavert deleted the AS-950-plus-unavailable branch January 24, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshanzel sshanzel sshanzel approved these changes

@rebelchris rebelchris rebelchris approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees

@capJavert capJavert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@capJavert @rebelchris @sshanzel