feat: add gift button to dropdowns #4092
Merged
+76
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This reverts commit 3f53473.
AmarTrebinjac
changed the title
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
AmarTrebinjac
commented
Jan 24, 2025
| openModal({ | ||
| type: LazyModal.GiftPlus, | ||
| props: { | ||
| preselected: comment.author as UserShortProfile, |
There was a problem hiding this comment.
@sshanzel is there maybe an even simpler profile type we can use in the gift modal so that we dont have to pass "as userShortProfile" a lot of places? Stuff like reputation, createdAt etc aren't always required in many places, but are in UserShortProfile
There was a problem hiding this comment.
They are pretty much the same if I'm not mistaken. So we can probably just delete one or the other. I would recommend deleting the Author since the UserShortProfile is directly based from a GraphQL fragment. And also that the Author from GraphQL is based from the same fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-754.preview.app.daily.dev