fix: add a close button to comment input

[tu2463]

Changes

This PR resolves #1606 dailydotdev/daily#1606

• Added a CloseButton component to the MarkdownInput component, so that we can see a "X" on the top-right corner of the comment box.

• Let CommentInputOrModal passes onClose to CommentMarkdownInput as a prop "onRequestClose". This function is eventually passed to MarkdownInput, so that clicking the close button can cancel the comment.

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

1. Go to a post
2. Click on comment button
3. Should see the comment box with a close button. Clicking the close button will cancel the comment.

-->

[vercel]

@tu2463 is attempting to deploy a commit to the Daily Dev Team on Vercel.

A member of the Team first needs to authorize it.

[sshanzel]

Great work! Thank you for your effort 🙏

After this, there should be two components we'll need to update to make this work on desktop. The MainComment and SubComment components contain a conditional render on the input field we display, we should pass the onRequestClose value to be a function that clears the state that manages the input itself.

[CLAassistant]

All committers have signed the CLA.

[jullia02]

After this, there should be two components we'll need to update to make this work on desktop. The MainComment and SubComment components contain a conditional render on the input field we display, we should pass the onRequestClose value to be a function that clears the state that manages the input itself.

Thank you for your feedback! We've updated both components to pass the onRequestClose prop, so it clears the input state as requested. We've also reviewed your inline comments and incorporated the changes.

Please let us know if there's anything else you'd like adjusted. 😄

[sshanzel]

Amazing work by both you 👏 👏 👏

Just the suggested commits, then we should be good to go! 🚀

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
daily-webapp	✅ Ready (Inspect)	Visit Preview	Dec 6, 2024 5:29am

[sshanzel]

Just to avoid any conflict. I shall test this thoroughly tomorrow and see if we can merge 🥳

[sshanzel]

@tu2463 @jullia02 thank you both for your efforts. We've now merged your work, and should be seen within the app in a few minutes 🥳 🙏