feat: onboarding plus step #3869
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…onboarding-plus-step
ilasw
requested review from
rebelchris,
omBratteng,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
packages/webapp/pages/onboarding.tsx
Outdated
| @@ -224,6 +230,15 @@ export function OnboardPage(): ReactElement { | |||
| return setActiveScreen(OnboardingStep.Sources); | |||
| } | |||
|
|
|||
| if ( | |||
| (showOnboardingSources && activeScreen === OnboardingStep.Sources) || | |||
There was a problem hiding this comment.
Is this not going to be behind any existing experiment we have for plus subscription?
There was a problem hiding this comment.
sources is a running experiment, you can't rely on it yet.
There was a problem hiding this comment.
It should actually be it's own evaluation experiment
| ]; | ||
|
|
||
| export const plusFeatureList = [ | ||
| 'Ads-free browsing', |
There was a problem hiding this comment.
| 'Ads-free browsing', | |
| 'Everything on Free plan', | |
| 'Ads-free browsing', |
| return ( | ||
| <li className="flex gap-2"> | ||
| <ChecklistAIcon className="text-text-quaternary" size={IconSize.Small} /> | ||
| <ChecklistAIcon | ||
| className="text-text-quaternary" |
There was a problem hiding this comment.
I'm not sure about other places, but here, I think the color should be tertiary.
| logSubscriptionEvent: (event: LogSubscriptionEvent) => void; | ||
| } => { | ||
| const { user } = useAuthContext(); | ||
| const isPlus = user?.isPlus || false; | ||
| const plusSubscriptionFeature = useFeature(feature.plusSubscription); | ||
| const isOnboardingPlusActive = useFeature(feature.onboardingPlus); |
There was a problem hiding this comment.
Oh the only issue here is that it will enroll everyone as soon as they hit onboarding page, and actually anytime this hook gets called even.
Did you check enrollment with ido in #experiment channel?
packages/webapp/pages/onboarding.tsx
Outdated
| if (isOnboardingPlusActive) { | ||
| logSubscriptionEvent({ | ||
| event_name: 'skip upgrade subscription', | ||
| target_id: 'onboarding', |
There was a problem hiding this comment.
Both these should be enums in log file
…feat-onboarding-plus-step
| @@ -281,6 +284,7 @@ export enum TargetId { | |||
| Ads = 'ads', | |||
| MyProfile = 'my profile', | |||
| PlusBadge = 'plus badge', | |||
| Onboarding = 'onboarding', | |||
There was a problem hiding this comment.
I think we have this already, but maybe not id?
There was a problem hiding this comment.
We have it on Origin, should I use this instead?
Changes
Events
Did you introduce any new tracking events?
Experiment
Not anymore, according to #experiments channel thread
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-onboarding-plus-step.preview.app.daily.dev