chore: cleanup post_title_language experiment (won) #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
capJavert
approved these changes
Sep 2, 2024
| @@ -22,7 +20,7 @@ type Props = { | |||
|
|
|||
| const defaultIcon = <LanguageIcon className="ml-0 mr-1" />; | |||
|
|
|||
| const LanguageDropdownDefault = ({ | |||
| export const LanguageDropdown = ({ | |||
There was a problem hiding this comment.
We should also see down the line (after some more adoption?) to make language required in registration flow on API? (not blocker for this PR)
There was a problem hiding this comment.
Yeah correct indeed :) 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Experiment post_title_language won
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-545 #done
Preview domain
https://as-545-cleanup-post-title-langua.preview.app.daily.dev