fix: comment tracking #2880
Merged
fix: comment tracking #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
DragosIorgulescu,
omBratteng,
capJavert,
kopancek,
sshanzel,
nensidosari and
idoshamun
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
idoshamun
approved these changes
Mar 28, 2024
capJavert
approved these changes
Mar 28, 2024
| @@ -90,7 +140,7 @@ export default function MainComment({ | |||
| contentVisibility: initialInView ? 'visible' : 'auto', | |||
| }} | |||
| > | |||
| {!editProps && inView && ( | |||
| {!editProps && (trackImpression || inView) && ( | |||
There was a problem hiding this comment.
Only issue I see is that this renders all the comments that are currently loaded no matter if they are in view or not, which contradicts what lazy prop means.
There was a problem hiding this comment.
I think it can be fixed by extracting lazy logic into a wrapper component which can then be used in specific places like post page.
<LazyComment>
<MainComment />
</LazyComment>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Describe what this PR does
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
WT-{number} #done
Preview domain
https://fix-comment-tracking.preview.app.daily.dev