Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup all text colors #2872

Merged
merged 2 commits into from
Mar 28, 2024
Merged

chore: cleanup all text colors #2872

merged 2 commits into from
Mar 28, 2024

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 27, 2024

Changes

Describe what this PR does

  • Refactor all text colors to use new naming conventions.
  • (Lots of changes as they touch about everything)

🚨 Be aware with open PR's as they might re-introduce colors that no longer work now 🚨

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-{number} #done

Preview domain

https://chore-cleanup-text-colors.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner March 27, 2024 12:47
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 8:17am
storybook 🔄 Building (Inspect) Visit Preview Mar 28, 2024 8:17am

Copy link
Contributor

@nensidosari nensidosari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

few comments just for check

@nensidosari nensidosari requested a review from a team March 27, 2024 15:30
@rebelchris rebelchris merged commit f4a4090 into main Mar 28, 2024
2 of 4 checks passed
@rebelchris rebelchris deleted the chore-cleanup-text-colors branch March 28, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants