Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header spacing on both squad and collections posts. #2866

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Mar 27, 2024

Changes

  • Since our new header navigation has all the necessary actions, the old one is not needed anymore.
  • Fixed squad post spacing.

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

MI-242 #done

Preview domain

https://fix-header-spacing.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner March 27, 2024 06:20
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:40am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Mar 27, 2024 6:40am

@rebelchris rebelchris requested a review from a team March 27, 2024 06:23
@sshanzel
Copy link
Member Author

Previews:
Screenshot 2024-03-27 at 2 28 45 PM

Screenshot 2024-03-27 at 2 40 55 PM

@sshanzel sshanzel merged commit afaf52a into main Mar 27, 2024
6 checks passed
@sshanzel sshanzel deleted the fix-header-spacing branch March 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants