fix: go back navigation #2862
Merged
fix: go back navigation #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nensidosari
approved these changes
Mar 26, 2024
| 'invisible' | ||
| } | ||
| onClick={router.back} | ||
| className={!canGoBack && 'invisible'} |
There was a problem hiding this comment.
Should we just do hidden rather then invisible?
There was a problem hiding this comment.
We want to keep the height consistent, so we used invisible. We can use either of the two, just saw some benefits here.
Comment on lines
15
to
16
| globalThis?.history && | ||
| !!globalThis.history.length && |
There was a problem hiding this comment.
Why didn't u reuse !!globalThis?.window?.history?.length for these?
There was a problem hiding this comment.
The condition isNullOrUndefined(globalThis.history.state.options.shallow) would be true if the globalThis?.history?.state is used.
There was a problem hiding this comment.
Changed the condition to make it easier to understand.
sshanzel
force-pushed
the
fix-navigation
branch
from
61ee1ae to
8bdf347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
WT-{number} #done
Preview domain
https://fix-navigation.preview.app.daily.dev