feat: update profile actions on mobile #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
- use the `FormWrapper` component for consistency
DragosIorgulescu
force-pushed
the
MI-134-edit-account-mobile
branch
from
c5a8f3c to
f05462b
Compare
rebelchris
reviewed
Mar 25, 2024
rebelchris
approved these changes
Mar 25, 2024
nensidosari
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Looks good, small suggestions on my side.
One thing I noticed in the recording, on mobile when we submit the profile changes we need to click cancel after to go back to the profile page... 😬 Maybe this is what is suggested by product, but seems like a weird behaviour to me
@nensidosari fair point, I made an update and now it works like this: Screen.Recording.2024-03-26.at.13.24.46.mov |
# Conflicts: # packages/webapp/pages/account/profile.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FormWrappercomponent for consistencyPreview
Screen.Recording.2024-03-25.at.17.40.24.mov
Events
N / A
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
MI-134 #done
Preview domain
https://mi-134-edit-account-mobile.preview.app.daily.dev