feat: mobile feed layout & nav bar #2856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nensidosari
reviewed
Mar 25, 2024
8 tasks
sshanzel
reviewed
Mar 25, 2024
Noticed this feed settings button staying in the middle here
|
DragosIorgulescu
force-pushed
the
MI-130-layout-feed
branch
from
ce3f16b to
b09cef1
Compare
DragosIorgulescu
force-pushed
the
MI-130-layout-feed
branch
from
2731daa to
2599e93
Compare
DragosIorgulescu
force-pushed
the
MI-130-layout-feed
branch
from
acf6343 to
656fb9b
Compare
- adding a `FeedNav` at the top of the feed layout - updating footer nav items - moving reading streaks to the top of the `for you` feed TODO: - go through all pages and make sure the layout is not broken - validate the previous layout still looks the same if the feature flag is disabled
- applied to popular, upvoted and discussed feeds - adding the selector to the feed empty screen component as well
- update layout margins to take into account the new sidebar for bookmarks and history
- otherwise it's clipped when there is a counter badge on it
DragosIorgulescu
force-pushed
the
MI-130-layout-feed
branch
from
c2b69cb to
63ad9d8
Compare
|
Closing this as we will be using #2855 to track and review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FeedNavat the top of the feed layoutfor youfeedTODO:
Previews
Describe what this PR does
Events
N / A
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
MI-130
Preview domain
https://mi-130-layout-feed.preview.app.daily.dev