fix: date comparison without timezone in consideration (#3832)

dailydotdev · Nov 21, 2024 · 9314871 · 9314871
1 parent b368818
commit 9314871
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/packages/shared/src/components/streak/ReadingStreakButton.tsx b/packages/shared/src/components/streak/ReadingStreakButton.tsx
@@ -75,7 +75,8 @@ export function ReadingStreakButton({
   const isMobile = useViewSize(ViewSize.MobileL);
   const [shouldShowStreaks, setShouldShowStreaks] = useState(false);
   const hasReadToday =
-    new Date(streak?.lastViewAt).getDate() === new Date().getDate();
+    streak?.lastViewAtTz &&
+    new Date(streak.lastViewAtTz).getDate() === new Date().getDate();
 
   const handleToggle = useCallback(() => {
     setShouldShowStreaks((state) => !state);

diff --git a/packages/shared/src/graphql/fragments.ts b/packages/shared/src/graphql/fragments.ts
@@ -332,6 +332,7 @@ export const USER_STREAK_FRAGMENT = gql`
     total
     current
     lastViewAt
+    lastViewAtTz
     weekStart
   }
 `;

diff --git a/packages/shared/src/graphql/users.ts b/packages/shared/src/graphql/users.ts
@@ -498,6 +498,7 @@ export interface UserStreak {
   current: number;
   weekStart: DayOfWeek;
   lastViewAt: Date;
+  lastViewAtTz: Date;
 }
 
 export const getReadingStreak = async (): Promise<UserStreak> => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -332,6 +332,7 @@ export const USER_STREAK_FRAGMENT = gql` @@
         total
         current
         lastViewAt
+        lastViewAtTz
         weekStart
       }
     `;
@@ Expand Down @@