fix: change squad activeFeed name to reflect new path; (#3608)

* fix: change squad activeFeed name to reflect new path; * fix: update ts type to reflect changes
dailydotdev · Oct 2, 2024 · 6b2a95b · 6b2a95b
1 parent 0a68b0b
commit 6b2a95b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 24 deletions.
diff --git a/packages/shared/src/components/feeds/FeedContainer.tsx b/packages/shared/src/components/feeds/FeedContainer.tsx
@@ -109,29 +109,14 @@ const getStyle = (isList: boolean, space: Spaciness): CSSProperties => {
 };
 
 const feedNameToHeading: Record<
-  Exclude<
+  Extract<
     FeedPagesWithMobileLayoutType,
-    | 'user-upvoted'
-    | 'user-posts'
-    | 'squads[handle]'
-    | 'tags[tag]'
-    | 'sources[source]'
-    | 'search-bookmarks'
-    | 'sources[source]/most-upvoted'
-    | 'sources[source]/best-discussed'
-    | 'tags[tag]/most-upvoted'
-    | 'tags[tag]/best-discussed'
-    | SharedFeedPage.Custom
-    | SharedFeedPage.CustomForm
-    | OtherFeedPage.Explore
-    | OtherFeedPage.ExploreLatest
-    | OtherFeedPage.ExploreUpvoted
-    | OtherFeedPage.ExploreDiscussed
-    | OtherFeedPage.Tags
-    | OtherFeedPage.Sources
-    | OtherFeedPage.Leaderboard
-    | OtherFeedPage.FeedByIds
-    | OtherFeedPage.Welcome
+    | SharedFeedPage.Search
+    | SharedFeedPage.MyFeed
+    | SharedFeedPage.Popular
+    | SharedFeedPage.Upvoted
+    | OtherFeedPage.Discussed
+    | OtherFeedPage.Bookmarks
   >,
   string
 > = {

diff --git a/packages/shared/src/lib/query.ts b/packages/shared/src/lib/query.ts
@@ -26,8 +26,8 @@ import {
 export enum OtherFeedPage {
   Tag = 'tag',
   Tags = 'tags',
-  Squad = 'squads',
-  SquadPage = 'squads[handle]',
+  Squad = 'squadsdiscover',
+  SquadPage = 'squadsdiscover[id]',
   Source = 'source',
   Sources = 'sources',
   Leaderboard = 'users',