Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing stats for Android #41

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fixing stats for Android #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a71ba
Fixing stats for Android
filipi87 Mar 27, 2024
3d6486e
Bumping version
filipi87 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/src/main/java/com/oney/WebRTCModule/PeerConnectionObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ public void receiverGetStats(String receiverId, Promise promise) {
}

public void senderGetStats(String senderId, Promise promise) {
RtpReceiver targetSender = null;
for (RtpReceiver r : peerConnection.getReceivers()) {
if (r.id().equals(senderId)) {
targetSender = r;
RtpSender targetSender = null;
for (RtpSender s : this.peerConnection.getSenders()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question: here you added this. -- Do we need to change that in receiverGetStats() too? or was the addition of this somehow not necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keyword is used to refer to the current instance of the class in which it appears. But it is not mandatory, it is just to make it more explicit.

if (s.id().equals(senderId)) {
targetSender = s;
break;
}
}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@daily-co/react-native-webrtc",
"version": "118.0.3-daily.1",
"version": "118.0.3-daily.2",
"repository": {
"type": "git",
"url": "git+https://github.com/daily-co/react-native-webrtc.git"
Expand Down
Loading