Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set S3 bucket to have versioning enabled #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rweald
Copy link

@rweald rweald commented Nov 20, 2024

Thanks for creating this repo, very helpful in getting things setup for cloud storage quickly and confidently. Noticed this 1 small thing when comparing this config with the docs, and thought I'd be helpful and open a PR rather than just complain about it.

Documentation website states that s3 bucket needs to have versioning enabled on it. Therefore we should setup CDK to create the bucket with that explicit config.

From the documentation

The target S3 bucket to which you want recordings to be stored can be in any AWS region and must have versioning enabled. Please be sure to select "Enable" under "Bucket Versioning" when creating your S3 bucket for recording storage.

Documentation website states that s3 bucket needs to have versioning
enabled on it. Therefore we should setup CDK to create the bucket with
that explicit config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant