add local dev and update docs for Sling #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
slopp
approved these changes
Apr 10, 2024
izzye84
reviewed
Apr 10, 2024
| - you will also need to install the packages in the "sling" extra (e.g. `pip install -e ".[dev,sling]")`) | ||
| - You'll need to obtain the credentials for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY | ||
| - then run `dagster dev` and both `hooli_demo_assets` and `hooli_data_eng` code locations will load | ||
| - NOTE: if you are running Sling locally, there is currently an error message if you already have a duckdb database set up the first time you run the Sling integration. You'll need to delete it and have the `location` asset be the the first thing you materialize. |
There was a problem hiding this comment.
Not to hold up this PR, but did you happen to create a bug for this? I vaguely remember running into it way back when.
There was a problem hiding this comment.
You mean on Sling's repo or here for us? Either way I didn't but can do
There was a problem hiding this comment.
I think we should raise it internally and then we can decide if it should go back to Sling too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Sling loader was failing in prod, and I wanted to debug it. There must have been an update to Sling between version upgrades because we needed to change the AWS_BUCKET from
s3://{bucket_name}/{folder_path}(old) to just{bucket_name}. That was an env var change which is now live, but for me to figure that out I had to get the local version working. This PR adds that local support:setup.pyto includedagster-embedded-elt