make amps work better for hooli #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
izzye84
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some long standing problem's in Hooli's use of experimental auto-materialization policies, specifically the case of daily partitioned assets -> weekly partitioned assets -> unpartitioned assets.
The customized policy now makes it so that any change to a daily partition will cause downstream assets to materialize, essentially making AMPs more aggressive. This change helps us demo how changes propagate through the system.
We also remove lazy policies which just didn't work in these situations.
Tradeoffs:
The remaining freshness policies are now useful for alerting only, they no longer dictate run behavior.
The change to use a customized AMP means the AMP policies must be defined in code and not in the dbt model config.