Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update CSS for superseded and deprecated flags #26972

Merged

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jan 9, 2025

Summary & Motivation

Updates the CSS for superseded and deprecated flags as discussed here

@maximearmstrong maximearmstrong self-assigned this Jan 9, 2025
@maximearmstrong maximearmstrong marked this pull request as ready for review January 9, 2025 15:38
Copy link
Member

@hellendag hellendag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as long as it's correct for the deprecated tag to be orange and the superseded tag to be yellow`, then this looks good to me. Thanks for cleaning it up!

@maximearmstrong maximearmstrong force-pushed the maxime/api-lifecycle-styling-for-docs-beta branch from 24ced52 to b934bf3 Compare January 9, 2025 15:41
@maximearmstrong maximearmstrong force-pushed the maxime/fix-superseded-deprecated-css-classes branch from 58def29 to c5b6013 Compare January 9, 2025 15:41
Copy link

github-actions bot commented Jan 9, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-i1u9balg3-elementl.vercel.app
https://maxime-fix-superseded-deprecated-css-classes.dagster.dagster-docs.io

Direct link to changed pages:

@maximearmstrong maximearmstrong force-pushed the maxime/api-lifecycle-styling-for-docs-beta branch from b934bf3 to 649a2ab Compare January 9, 2025 16:32
@maximearmstrong maximearmstrong force-pushed the maxime/fix-superseded-deprecated-css-classes branch from c5b6013 to 6e7dfa2 Compare January 9, 2025 16:32
@maximearmstrong maximearmstrong force-pushed the maxime/api-lifecycle-styling-for-docs-beta branch from 649a2ab to 979a328 Compare January 9, 2025 17:01
@maximearmstrong maximearmstrong force-pushed the maxime/fix-superseded-deprecated-css-classes branch from 6e7dfa2 to f19f4d6 Compare January 9, 2025 17:01
Base automatically changed from maxime/api-lifecycle-styling-for-docs-beta to master January 9, 2025 20:13
@maximearmstrong maximearmstrong merged commit 91dd09e into master Jan 9, 2025
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/fix-superseded-deprecated-css-classes branch January 9, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants