Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] revert pathPrefix prop for CodeExample #26862

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Jan 6, 2025

Summary & Motivation

  • raw-loader loads the examples/ folder in its entirety due to not being able to know what pathPrefix is being provided. This removes pathPrefix which isn't being used yet, to more efficiently load modules.

How I Tested These Changes

Changelog

NOCHANGELOG

@cmpadden cmpadden requested a review from neverett as a code owner January 6, 2025 22:08
Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-fduj7w6uq-elementl.vercel.app

Direct link to changed pages:

Copy link
Contributor

@C00ldudeNoonan C00ldudeNoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to revert this right now for performance purposes, we can look into it and come up with a better solution when we have an example to include

@C00ldudeNoonan C00ldudeNoonan merged commit 0eec862 into master Jan 7, 2025
3 checks passed
@C00ldudeNoonan C00ldudeNoonan deleted the colton/revert-code-example-path-prefix branch January 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants