Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document bare check result in op behavior #26726

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Dec 26, 2024

Summary & Motivation

Test behavior when a bare asset check result is yielded inside an op (both invocation and execution).

Similar test cases exist elsewhere; but I think it's useful to have one specifically targeted at the op decorator.

Copy link
Contributor Author

dpeng817 commented Dec 26, 2024

@dpeng817 dpeng817 requested a review from OwenKephart December 26, 2024 19:14
@dpeng817 dpeng817 marked this pull request as ready for review December 26, 2024 19:14
@dpeng817 dpeng817 force-pushed the dpeng817/document_bare_check_result branch from 608bcf7 to 1047808 Compare December 26, 2024 19:45
@dpeng817 dpeng817 force-pushed the dpeng817/test_dynamic_outputs_and_assets_behavior branch from ef247df to 28c74fd Compare December 27, 2024 16:20
@dpeng817 dpeng817 force-pushed the dpeng817/document_bare_check_result branch from 1047808 to 689793c Compare December 27, 2024 16:20
@dpeng817 dpeng817 force-pushed the dpeng817/document_bare_check_result branch from 689793c to 62f6c59 Compare January 6, 2025 19:04
@dpeng817 dpeng817 requested a review from neverett as a code owner January 6, 2025 19:04
@dpeng817 dpeng817 changed the base branch from dpeng817/test_dynamic_outputs_and_assets_behavior to master January 6, 2025 19:04
@graphite-app graphite-app bot added the docs-to-migrate Docs to migrate to new docs site label Jan 6, 2025
Copy link

graphite-app bot commented Jan 6, 2025

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (01/06/25)

1 label was added to this PR based on Christopher DeCarolis's automation.

@dpeng817 dpeng817 merged commit 9d6c964 into master Jan 6, 2025
6 of 7 checks passed
@dpeng817 dpeng817 deleted the dpeng817/document_bare_check_result branch January 6, 2025 19:05
Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-1z238ko37-elementl.vercel.app
https://dpeng817-document-bare-check-result.components-storybook.dagster-docs.io

Built with commit 62f6c59.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-mii1j6vlp-elementl.vercel.app
https://dpeng817-document-bare-check-result.core-storybook.dagster-docs.io

Built with commit 62f6c59.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-m362qxgar-elementl.vercel.app
https://dpeng817-document-bare-check-result.dagster-university.dagster-docs.io

Built with commit 62f6c59.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-kkyeneu3y-elementl.vercel.app
https://dpeng817-document-bare-check-result.dagster.dagster-docs.io

Direct link to changed pages:

Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-mad13vsso-elementl.vercel.app

Direct link to changed pages:

@neverett neverett removed the docs-to-migrate Docs to migrate to new docs site label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants