Use markdown for images in new docs #26645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
cmpadden
approved these changes
Dec 20, 2024
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-nt54jo4ie-elementl.vercel.app Direct link to changed pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Since we don't have dark theme images for old screenshots, let's just format images with Markdown for now instead of using the ThemedImage` component. Later, we'll do a big screenshot sweep to create dark theme images and switch from Markdown to the component.
How I Tested These Changes
Changelog