[ui] Update DA evaluation page to show backfill in table if a backfill was requested #26643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit aabed95. |
salazarm
reviewed
Dec 23, 2024
| () => (selectedEvaluation?.runIds.length ? {runIds: selectedEvaluation.runIds} : null), | ||
| () => | ||
| selectedEvaluation?.runIds.length | ||
| ? selectedEvaluation.runIds.length === 1 && selectedEvaluation.runIds[0]?.length === 8 |
There was a problem hiding this comment.
why does this length need to be 8 ?
There was a problem hiding this comment.
That's the length of a backfill id
There was a problem hiding this comment.
So wait, can't there be multiple runIds ?
salazarm
approved these changes
Dec 23, 2024
jamiedemaria
force-pushed
the
jamie/da-table-shows-backfills
branch
from
f2373ce to
997a5eb
Compare
jamiedemaria
force-pushed
the
jamie/da-table-shows-backfills
branch
from
cbaa1ab to
aabed95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The runs table for a DA evaluation was not showing backfills when DA requested a backfill
This is because the the
selectedEvaluation.runIdscould be run ids or a backfill id, but we were always adding them as run id filters. Then the value was a backfill id, it would return no results.This add some (admittedly a bit hacky) logic to determine if the id is a backfill id, and set the correct filter if so. A more long term solution would be to store run ids and backfill ids as separate lists on the evaluation, but this will fix the problem until we can make the more sustainable change.
I also had to update the
RunsFeedTableWithFilterscomponent to take a boolincludeRunsFromBackfillsso that we would only show the backfill row, not the runs that the backfill launched. I had to then update all of the users ofRunsFeedTableWithFiltersto pass the boolHow I Tested These Changes
👀
Changelog
[ui] Fixed a bug where backfills launched by Declarative Automation were not being shown in the table of launched runs