Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-beta] migrate - CI/CD docs #26508

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[docs-beta] migrate - CI/CD docs #26508

merged 3 commits into from
Dec 20, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Dec 15, 2024 •
edited
Loading

Summary & Motivation

Marked the following links as /todo:

  - Broken link on source page path = /dagster-plus/features/ci-cd/branch-deployments/change-tracking:
     -> linking to /dagster-plus/managing-deployments/branch-deployments/using-branch-deployments
     -> linking to /guides/dagster/asset-versioning-and-caching
     -> linking to /concepts/metadata-tags/tags
     -> linking to /concepts/metadata-tags/asset-metadata#attaching-definition-metadata
  - Broken link on source page path = /dagster-plus/features/ci-cd/branch-deployments/dagster-cloud-cli:
     -> linking to /dagster-plus/account/managing-user-agent-tokens
  - Broken link on source page path = /dagster-plus/features/ci-cd/branch-deployments/testing:
     -> linking to /concepts/assets/software-defined-assets
     -> linking to /concepts/ops-jobs-graphs/ops
     -> linking to /concepts/ops-jobs-graphs/graphs
     -> linking to /concepts/assets/asset-jobs
     -> linking to /concepts/resources
     -> linking to /concepts/io-management/io-managers
     -> linking to /dagster-plus/managing-deployments/branch-deployments/using-branch-deployments-with-github
     -> linking to /dagster-plus/managing-deployments/branch-deployments/using-branch-deployments-with-gitlab
     -> linking to /dagster-plus/account/managing-users/managing-user-roles-permissions
     -> linking to /dagster-plus/managing-deployments/reserved-environment-variables
     -> linking to /dagster-plus/managing-deployments/environment-variables-and-secrets

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

@cmpadden cmpadden added the area:docs-revamp Related to the revamp of the docs label Dec 16, 2024
@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-bylh3u1ki-elementl.vercel.app

Direct link to changed pages:

@cmpadden cmpadden marked this pull request as ready for review December 20, 2024 20:35
C00ldudeNoonan
C00ldudeNoonan approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@C00ldudeNoonan C00ldudeNoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cmpadden cmpadden merged commit c03453b into master Dec 20, 2024
1 of 3 checks passed
@cmpadden cmpadden deleted the colton/doc-597-cicd-docs branch December 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C00ldudeNoonan C00ldudeNoonan C00ldudeNoonan approved these changes

@neverett neverett Awaiting requested review from neverett neverett is a code owner

@dehume dehume Awaiting requested review from dehume

Assignees
No one assigned
Labels
area:docs-revamp Related to the revamp of the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmpadden @neverett @C00ldudeNoonan