[ui] Upgrade styled-components to v6 #26280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
commented
Dec 4, 2024
| // For other elements, forward all props | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a noteworthy change. See comment.
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 92398f6. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 92398f6. |
[INTERNAL_BRANCH=dish/plus-styled-components]
hellendag
force-pushed
the
dish/styled-components-6
branch
from
0614b9b to
92398f6
Compare
salazarm
approved these changes
Dec 5, 2024
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Summary & Motivation Upgrade styled-components to v6, based on https://styled-components.com/docs/faqs. ## How I Tested These Changes Navigate throughout app, verify that components render and behave correctly. This affects the entire app, so we need to be vigilant about spotting and fixing bugs after this merges.
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Upgrade styled-components to v6, based on https://styled-components.com/docs/faqs. ## How I Tested These Changes Navigate throughout app, verify that components render and behave correctly. This affects the entire app, so we need to be vigilant about spotting and fixing bugs after this merges.
hellendag
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 1a2a067. [INTERNAL_BRANCH=dish/plus-revert-sc-6]
hellendag
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 1a2a067. [INTERNAL_BRANCH=dish/plus-revert-sc-6]
hellendag
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 1a2a067. kick the build [INTERNAL_BRANCH=dish/plus-revert-sc-6]
hellendag
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 1a2a067. [INTERNAL_BRANCH=dish/plus-revert-sc-6]
hellendag
added a commit
that referenced
this pull request
Dec 20, 2024
## Summary & Motivation We've seen reports of styles failing to be applied in the app in certain (very difficult to reproduce) conditions, and the recent styled-components upgrade seems like a possible culprit. Revert to try to resolve the issue. ## How I Tested These Changes TS/lint/jest. Load the app, verify that everything renders as expected. ## Changelog [ui] FIx an issue where the app sometimes loads with styles missing.
gibsondan
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Summary & Motivation We've seen reports of styles failing to be applied in the app in certain (very difficult to reproduce) conditions, and the recent styled-components upgrade seems like a possible culprit. Revert to try to resolve the issue. ## How I Tested These Changes TS/lint/jest. Load the app, verify that everything renders as expected. ## Changelog [ui] FIx an issue where the app sometimes loads with styles missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Upgrade styled-components to v6, based on https://styled-components.com/docs/faqs.
How I Tested These Changes
Navigate throughout app, verify that components render and behave correctly. This affects the entire app, so we need to be vigilant about spotting and fixing bugs after this merges.