[ui] Add min-height to breadcrumbs to fix layout loop caused by MiddleTruncate RAF #26127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
changed the title
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 3a2bf15. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 3a2bf15. |
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
…eTruncate RAF (#26127) ## Summary & Motivation Fixes the flickering observed in https://dagsterlabs.slack.com/archives/C03CZRZCZQQ/p1732546935350479. When the sizing is async, the height of the element was briefly reduced to the height of the `•••`, which causes an infinite loop of re-rendering. The "30px" minimum height is the default value that would be set if we were not overriding it here. Also added a storybook so we can easily verify this behavior in the future: <img width="931" alt="image" src="https://github.com/user-attachments/assets/5430f23a-f437-407c-97a1-336b6e09c67e"> ## How I Tested These Changes I added a storybook with the same code as the header and verified the flickering is no longer an issue. Co-authored-by: bengotow <[email protected]>
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…eTruncate RAF (dagster-io#26127) ## Summary & Motivation Fixes the flickering observed in https://dagsterlabs.slack.com/archives/C03CZRZCZQQ/p1732546935350479. When the sizing is async, the height of the element was briefly reduced to the height of the `•••`, which causes an infinite loop of re-rendering. The "30px" minimum height is the default value that would be set if we were not overriding it here. Also added a storybook so we can easily verify this behavior in the future: <img width="931" alt="image" src="https://github.com/user-attachments/assets/5430f23a-f437-407c-97a1-336b6e09c67e"> ## How I Tested These Changes I added a storybook with the same code as the header and verified the flickering is no longer an issue. Co-authored-by: bengotow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes the flickering observed in https://dagsterlabs.slack.com/archives/C03CZRZCZQQ/p1732546935350479. When the sizing is async, the height of the element was briefly reduced to the height of the
•••, which causes an infinite loop of re-rendering. The "30px" minimum height is the default value that would be set if we were not overriding it here.Also added a storybook so we can easily verify this behavior in the future:
How I Tested These Changes
I added a storybook with the same code as the header and verified the flickering is no longer an issue.