[ui] Fix dark mode scrollbars #26033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit fc516c8. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fc516c8. |
braunjj
approved these changes
Nov 20, 2024
hellendag
force-pushed
the
dish/dark-scrollbars
branch
from
7ea26bb to
7fa4425
Compare
hellendag
force-pushed
the
dish/dark-scrollbars
branch
from
7fa4425 to
fc516c8
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Fix scrollbars in dark mode. - Use `dark` instead of `'dark'` as the color scheme value. This fixes the main issue, where we're rendering light-mode browser controls. I'm not sure if this has been broken since we shipped dark mode, or if something recently changed. Either way, sorry for leaving it broken for so long. - Style the scrollbar to use our themed colors, instead of the (mismatching) defaults. <img width="1098" alt="Screenshot 2024-11-20 at 08 31 03" src="https://github.com/user-attachments/assets/638d77b9-5add-4cc2-a2ba-0de7c2c68b40"> <img width="1098" alt="Screenshot 2024-11-20 at 08 31 18" src="https://github.com/user-attachments/assets/f062f452-0e97-42db-9311-07ba0017626b"> ## How I Tested These Changes Change MacOS settings to show scrollbars in all cases. Load an asset detail page, shrink the viewport to force scrollbars to appear. Verify that they look correct (including themed colors) in both dark mode and light mode. ## Changelog [ui] Fix scrollbars in dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix scrollbars in dark mode.
darkinstead of'dark'as the color scheme value. This fixes the main issue, where we're rendering light-mode browser controls. I'm not sure if this has been broken since we shipped dark mode, or if something recently changed. Either way, sorry for leaving it broken for so long.How I Tested These Changes
Change MacOS settings to show scrollbars in all cases. Load an asset detail page, shrink the viewport to force scrollbars to appear.
Verify that they look correct (including themed colors) in both dark mode and light mode.
Changelog
[ui] Fix scrollbars in dark mode.