CodeMirror lint: stop patching global lint #26013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 3c0c5f7. |
hellendag
approved these changes
Nov 20, 2024
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation We currently override CodeMirror's global lint addon with a custom implementation that conflicts with the original addon. This incompatibility surfaced while developing the new asset selection syntax input; specifically, loading the launchpad and then accessing the new syntax input triggers JavaScript errors due to the overridden lint behavior. To fix this issue, this PR stops patching the global lint addon and instead uses a separate patchedLint namespace. By doing so, our custom lint functionality is isolated to specific editor instances, allowing the original lint addon to operate correctly in other editors without interference. ## How I Tested These Changes Use the launchpad and see that it lints and surfaces errors correctly by starting with a valid config, adding invalid stuff, and then making it valid again and making sure we lint each step along the way. <img width="1089" alt="Screenshot 2024-11-19 at 3 41 55 PM" src="https://github.com/user-attachments/assets/c58e9637-42cf-4c28-9f75-5b5f50d1dce7"> <img width="908" alt="Screenshot 2024-11-19 at 3 42 28 PM" src="https://github.com/user-attachments/assets/74a66579-2a1f-487a-bfa5-a817793bd102"> <img width="784" alt="Screenshot 2024-11-19 at 3 42 20 PM" src="https://github.com/user-attachments/assets/b895f385-a0ad-42b4-bc8f-47944dc2e284">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We currently override CodeMirror's global lint addon with a custom implementation that conflicts with the original addon. This incompatibility surfaced while developing the new asset selection syntax input; specifically, loading the launchpad and then accessing the new syntax input triggers JavaScript errors due to the overridden lint behavior.
To fix this issue, this PR stops patching the global lint addon and instead uses a separate patchedLint namespace. By doing so, our custom lint functionality is isolated to specific editor instances, allowing the original lint addon to operate correctly in other editors without interference.
How I Tested These Changes
Use the launchpad and see that it lints and surfaces errors correctly by starting with a valid config, adding invalid stuff, and then making it valid again and making sure we lint each step along the way.