[4/4] Add asset selection input for new syntax #26000
Conversation
salazarm
changed the base branch from
master
to
salazarm/asset-selection-filtering
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 51dbb2c. |
|
|
||
| /** | ||
| * Ignore hard navigation error (only happens in dev mode). | ||
| */ | ||
| if (process.env.NODE_ENV === 'development' && typeof window !== 'undefined') { | ||
| const originalError = window.Error; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| window.Error = function Error(...args) { | ||
| if (args[0]?.includes('Invariant: attempted to hard navigate to the same URL')) { | ||
| return; | ||
| } | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| const err = originalError(...args); | ||
| Object.setPrototypeOf(err, window.Error.prototype); | ||
| return err; | ||
| }; | ||
| } |
There was a problem hiding this comment.
We don't need this anymore and it was changing error behavior in dev.
There was a problem hiding this comment.
Worth making this its own PR since it's otherwise unrelated?
There was a problem hiding this comment.
it's related in that this ends up changing the prototype of the error which breaks an instanceof check in Antlr which causes my code not to work
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 615f946. |
|
|
||
| /** | ||
| * Ignore hard navigation error (only happens in dev mode). | ||
| */ | ||
| if (process.env.NODE_ENV === 'development' && typeof window !== 'undefined') { | ||
| const originalError = window.Error; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| window.Error = function Error(...args) { | ||
| if (args[0]?.includes('Invariant: attempted to hard navigate to the same URL')) { | ||
| return; | ||
| } | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| const err = originalError(...args); | ||
| Object.setPrototypeOf(err, window.Error.prototype); | ||
| return err; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Worth making this its own PR since it's otherwise unrelated?
| @@ -194,7 +194,7 @@ export const NewConfigEditor = forwardRef<ConfigEditorHandle, ConfigEditorProps> | |||
| <StyledRawCodeMirror | |||
| value={configCode} | |||
| theme={['config-editor']} | |||
| options={options} | |||
| options={options as any} | |||
There was a problem hiding this comment.
I'll remove it, don't need it now that I changed the patched lint thing in the other PR. But no it's not because of the patched lint thing. It's expecting options that are not part of the official lint addon and so the types that the addon has cause an error.
salazarm
changed the title
## Summary & Motivation Adds an asset selection input that supports the new syntax and has auto-complete suggestions. For now this is behind a hidden feature flag. error state: <img width="990" alt="Screenshot 2024-11-19 at 1 49 11 AM" src="https://github.com/user-attachments/assets/e31986bd-f914-463f-a2d7-af590c86cbe5"> key/value suggestions: <img width="736" alt="Screenshot 2024-11-19 at 1 48 54 AM" src="https://github.com/user-attachments/assets/fb9cdd96-c4fd-4797-9e6c-2bcbc4d11984"> base suggestions: <img width="490" alt="Screenshot 2024-11-19 at 1 48 47 AM" src="https://github.com/user-attachments/assets/452a666a-fefe-46c8-8914-4db3aa483aaf"> ## How I Tested These Changes Manual testing for now until i figure out a good way to test CodeMirror... To enable the feature flag: ``` localStorage.setItem("DAGSTER_FLAGS", JSON.stringify({ ...JSON.parse(localStorage.DAGSTER_FLAGS), 'flagAssetSelectionSyntax': true })) ``` https://github.com/user-attachments/assets/d158f5e0-527c-4350-ac79-7c7518a11c60
Summary & Motivation
Adds an asset selection input that supports the new syntax and has auto-complete suggestions.
For now this is behind a hidden feature flag.
error state:
key/value suggestions:
base suggestions:
How I Tested These Changes
Manual testing for now until i figure out a good way to test CodeMirror...
To enable the feature flag:
Screen.Recording.2024-11-19.at.3.02.01.AM.mov