[demo] Passing in the LoadingContext through the blocking batch load fns #25270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @OwenKephart and the rest of your teammates on |
This was referenced Oct 15, 2024
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
2 times, most recently
from
4b561cd to
b0136c3
Compare
briantu
force-pushed
the
10-14-_demo_passing_in_the_loadingcontext_through_the_blocking_batch_load_fns
branch
from
b850e29 to
e86b8ad
Compare
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
from
9329171 to
6ab40ba
Compare
briantu
force-pushed
the
10-14-_demo_passing_in_the_loadingcontext_through_the_blocking_batch_load_fns
branch
from
e86b8ad to
4ccd03c
Compare
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
from
1fb4fec to
3d1e462
Compare
briantu
force-pushed
the
10-14-_demo_passing_in_the_loadingcontext_through_the_blocking_batch_load_fns
branch
from
ad5a821 to
06c074e
Compare
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
from
63527ad to
206d74c
Compare
briantu
force-pushed
the
10-14-_demo_passing_in_the_loadingcontext_through_the_blocking_batch_load_fns
branch
from
06c074e to
6ab2546
Compare
This was referenced Oct 18, 2024
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
5 times, most recently
from
0535e53 to
647eb5d
Compare
briantu
added a commit
that referenced
this pull request
Oct 22, 2024
## Summary & Motivation This lets us use the loading_context for get_asset_status_cache_values, which saves us from needing to re-fetch the asset records in here again. Copied from demo PR #25270 ## How I Tested These Changes Perf test before/after ``` pytest python_modules/dagster/dagster_tests/definitions_tests/declarative_automation_tests/perf_tests/test_perf.py ```
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
## Summary & Motivation This lets us use the loading_context for get_asset_status_cache_values, which saves us from needing to re-fetch the asset records in here again. Copied from demo PR dagster-io#25270 ## How I Tested These Changes Perf test before/after ``` pytest python_modules/dagster/dagster_tests/definitions_tests/declarative_automation_tests/perf_tests/test_perf.py ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title. This lets us use the loading_context for get_asset_status_cache_values, which saves us from needing to re-fetch the asset records in here again.
Also some other random stuff I was trying in order to improve overall perf
How I Tested These Changes
Perf tested before / after.
Changelog