Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Yarn 4.5.0 #25225

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[ui] Yarn 4.5.0 #25225

merged 1 commit into from
Oct 11, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Oct 11, 2024

Summary & Motivation

Stay on top of Yarn updates, upgrade packages to 4.5.0.

How I Tested These Changes

Buildkite

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag marked this pull request as ready for review October 11, 2024 15:23
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Oct 11, 2024
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Oct 11, 2024
@graphite-app graphite-app bot requested a review from PedramNavid October 11, 2024 15:23
Copy link

github-actions bot commented Oct 11, 2024

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-qweor66t3-elementl.vercel.app
https://dish-yarn-450-oss.dagster-university.dagster-docs.io

Built with commit c771a20.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Oct 11, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-l7w0f78g5-elementl.vercel.app
https://dish-yarn-450-oss.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that previews for DU, docs, and beta docs look as expected.

@cmpadden
Copy link
Contributor

Note that the Deploy Docs Revamp failed with:

node:internal/modules/cjs/loader:1143
  throw err;
  ^

Error: Cannot find module '/home/runner/work/dagster/dagster/docs/docs-beta/.yarn/releases/yarn-4.5.0.cjs'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.20.4```

@hellendag
Copy link
Member Author

Thanks for flagging that, taking a look now.

Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-h055c1sdb-elementl.vercel.app

Direct link to changed pages:

@hellendag hellendag merged commit 094db11 into master Oct 11, 2024
5 checks passed
@hellendag hellendag deleted the dish/yarn-450-oss branch October 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants