minor code fixes for dagster uni dbt course #24757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
added
the
area: dagster-university
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 0eec3a3. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-38cq8hwsb-elementl.vercel.app Direct link to changed pages: |
cmpadden
reviewed
Sep 25, 2024
|
|
||
| with open(constants.AIRPORT_TRIPS_FILE_PATH, 'rb') as file: | ||
| image_data = file.read() | ||
| @asset( |
There was a problem hiding this comment.
What is the difference in this block?
There was a problem hiding this comment.
the code block has a leading space which is a little tedious to copy over.
cmpadden
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog
Insert changelog entry or "NOCHANGELOG" here.
NEW(added new feature or capability)BUGFIX(fixed a bug)DOCS(added or updated documentation)