Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-aws] add BaseAWSPipesClient #24042

Closed
wants to merge 1 commit into from

Conversation

danielgafni
Copy link
Contributor

@danielgafni danielgafni commented Aug 29, 2024

Summary & Motivation

The new BaseAWSPipesClient allows standardizing the behavior of various AWS PIpes clients.

This includes:

  • common run method logic - logging, handling DagsterExecutionInterruptedError, calling other (abstract) methods
  • common interface: child classes must define _start, _wait_for_completion, _terminate, _read_messages
  • docs generation for the class itself and for the run method. Default docs generated from AWS service name look like this:

How I Tested These Changes

Changelog [New | Bug | Docs]

NOCHANGELOG

Copy link
Contributor Author

danielgafni commented Aug 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danielgafni and the rest of your teammates on Graphite Graphite

@danielgafni danielgafni marked this pull request as ready for review August 29, 2024 07:45
@danielgafni danielgafni force-pushed the add-BaseAWSPipesClient branch from c767e65 to e380677 Compare August 29, 2024 07:48
@danielgafni danielgafni changed the title add BaseAWSPipesClient [dagster-aws] add BaseAWSPipesClient Aug 29, 2024
@danielgafni danielgafni changed the title [dagster-aws] add BaseAWSPipesClient [dagster-aws] add BaseAWSPipesClient Aug 29, 2024
@danielgafni danielgafni requested a review from schrockn August 29, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant