-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-beta] project structure guide #23741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dagsterapidocs canceled.
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-a8z2akh2w-elementl.vercel.app Direct link to changed pages: |
PedramNavid
force-pushed
the
docs/revamp
branch
from
August 20, 2024 21:59
137ed67
to
a1e46b0
Compare
cmpadden
force-pushed
the
docs/revamp-project-structure
branch
from
August 21, 2024 18:59
e959213
to
f6382ee
Compare
cmpadden
changed the title
[docs/revamp] project structure guide
[docs-beta] project structure guide
Aug 21, 2024
cmpadden
commented
Aug 21, 2024
PedramNavid
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, but a couple comments that could be worth addressing
Co-authored-by: Pedram Navid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Definitions.merge
to encapsulate sub-project definitionscontent-templates/guides-no-steps.md
How I Tested These Changes
pnpm start