Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-beta] project structure guide #23741

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Aug 19, 2024

Summary & Motivation

  • Introduces a new "Project structure" guide to revamp our existing guide
  • Makes use of Definitions.merge to encapsulate sub-project definitions
  • Explains multiple structures technology / context / Dagster object
  • Follows content-templates/guides-no-steps.md

How I Tested These Changes

pnpm start

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for dagsterapidocs canceled.

Name Link
🔨 Latest commit e959213
🔍 Latest deploy log https://app.netlify.com/sites/dagsterapidocs/deploys/66c3a947d4944a0008a81cd1

Copy link

github-actions bot commented Aug 19, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-a8z2akh2w-elementl.vercel.app
https://docs-revamp-project-structure.dagster.dagster-docs.io

Direct link to changed pages:

@cmpadden cmpadden changed the base branch from docs/revamp to master August 21, 2024 18:55
@cmpadden cmpadden force-pushed the docs/revamp-project-structure branch from e959213 to f6382ee Compare August 21, 2024 18:59
@cmpadden cmpadden marked this pull request as ready for review August 21, 2024 19:37
@cmpadden cmpadden changed the title [docs/revamp] project structure guide [docs-beta] project structure guide Aug 21, 2024
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 21, 2024
docs/docs-beta/sidebars.ts Outdated Show resolved Hide resolved
@cmpadden cmpadden changed the base branch from master to docs/revamp August 21, 2024 20:14
@cmpadden cmpadden changed the base branch from docs/revamp to master August 21, 2024 20:14
Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but a couple comments that could be worth addressing

docs/docs-beta/docs/guides/project-structure.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/project-structure.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/project-structure.md Outdated Show resolved Hide resolved
@cmpadden cmpadden merged commit 645dc21 into master Aug 30, 2024
1 of 3 checks passed
@cmpadden cmpadden deleted the docs/revamp-project-structure branch August 30, 2024 17:50
Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-6w0gxue0c-elementl.vercel.app

Direct link to changed pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general docathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants