merge captured log manager / compute log manager #23531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prha
force-pushed
the
prha/merge_compute_log_manager
branch
from
7f7534c to
e994979
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-riyaa8sc3-elementl.vercel.app Direct link to changed pages: |
prha
force-pushed
the
prha/merge_compute_log_manager
branch
from
e994979 to
a0d6ada
Compare
prha
changed the title
alangenfeld
approved these changes
Aug 15, 2024
what exactly is the breaking change a user would encounter? |
|
I think if they implemented their own ComputeLogManager that used the CapturedLogManager interface, they'd get an import error, basically. |
|
probably very rare if any cases - is anything explicitly marked |
sryza
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Summary & Motivation Previously we asserted that the `compute_log_manager` conformed to the `CapturedLogManager` interface. This PR explicitly moves the `CapturedLogManager` interface into the `ComputeLogManager` abstract class. This is just for cognitive simplification and typing simplicity, so that we can just access `instance.compute_log_manager` everywhere. There's some question here whether this should be a breaking change or not (for `1.9`) ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Previously we asserted that the
compute_log_managerconformed to theCapturedLogManagerinterface.This PR explicitly moves the
CapturedLogManagerinterface into theComputeLogManagerabstract class. This is just for cognitive simplification and typing simplicity, so that we can just accessinstance.compute_log_managereverywhere.There's some question here whether this should be a breaking change or not (for
1.9)How I Tested These Changes
BK