Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project examples to remove Dagster code from __init__.py #23345

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jul 31, 2024

Summary & Motivation

This PR updates project examples to remove Dagster code from __init__.py:

  • project_fully_featured
  • project_analytics

How I Tested These Changes

Deployed locally
BK with existing tests

Copy link
Contributor Author

maximearmstrong commented Jul 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

@maximearmstrong maximearmstrong force-pushed the maxime/ds-375/remove-dagster-code-from-init-py-in-docs branch from 44b1d45 to c9cd6e3 Compare July 31, 2024 15:14
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch 2 times, most recently from c5f5418 to 2124dff Compare July 31, 2024 15:23
@maximearmstrong maximearmstrong force-pushed the maxime/ds-375/remove-dagster-code-from-init-py-in-docs branch from 5485c9d to 009d0bb Compare July 31, 2024 15:27
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 2124dff to b687189 Compare July 31, 2024 15:59
@maximearmstrong maximearmstrong self-assigned this Jul 31, 2024
@maximearmstrong maximearmstrong force-pushed the maxime/ds-375/remove-dagster-code-from-init-py-in-docs branch from 009d0bb to fbf7d39 Compare July 31, 2024 17:20
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from b687189 to 2796daf Compare July 31, 2024 17:20
@maximearmstrong maximearmstrong marked this pull request as ready for review August 1, 2024 13:26
@maximearmstrong maximearmstrong force-pushed the maxime/ds-375/remove-dagster-code-from-init-py-in-docs branch from fbf7d39 to df8e566 Compare August 1, 2024 13:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 2796daf to 16994c5 Compare August 1, 2024 13:38
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 1, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 1, 2024 13:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-375/remove-dagster-code-from-init-py-in-docs branch from df8e566 to 32844cf Compare August 5, 2024 21:27
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 16994c5 to 24ac6a8 Compare August 5, 2024 21:27
Base automatically changed from maxime/ds-375/remove-dagster-code-from-init-py-in-docs to master August 13, 2024 13:13
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 24ac6a8 to 6b0ba2b Compare August 13, 2024 13:14
@maximearmstrong maximearmstrong merged commit 6211fac into master Aug 13, 2024
1 check passed
@maximearmstrong maximearmstrong deleted the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch August 13, 2024 13:38
maximearmstrong added a commit that referenced this pull request Aug 13, 2024
## Summary & Motivation

This PR updates the URL to the file containing Definitions in
project-fully-featured. That was moved from #23316 to this PR to avoid
failure when running the doc tests - the file must exist before being
referenced, and it is updated in #23345.

## How I Tested These Changes

BK
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
…3345)

## Summary & Motivation

This PR updates project examples to remove Dagster code from
`__init__.py`:
- project_fully_featured
- project_analytics

## How I Tested These Changes

Deployed locally
BK with existing tests
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
## Summary & Motivation

This PR updates the URL to the file containing Definitions in
project-fully-featured. That was moved from #23316 to this PR to avoid
failure when running the doc tests - the file must exist before being
referenced, and it is updated in #23345.

## How I Tested These Changes

BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants