Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dagster-ext as dep of dagster #16703

Merged
merged 7 commits into from
Sep 22, 2023
Merged

add dagster-ext as dep of dagster #16703

merged 7 commits into from
Sep 22, 2023

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Sep 21, 2023

Summary & Motivation

adds dagster-ext as a dependency of dagster and to all of the tox files for all libraries

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jamiedemaria jamiedemaria marked this pull request as ready for review September 21, 2023 21:08
@github-actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-p63gwzw2t-elementl.vercel.app
https://jamie-dagster-ext-dep.components-storybook.dagster-docs.io

Built with commit a22890f.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-knxioa5fu-elementl.vercel.app
https://jamie-dagster-ext-dep.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dagster-ext just needs to be added as an editable to the two "source" Dockerfiles in backcompat test suite and then this should be good to go!

Thanks for doing this.

@jamiedemaria jamiedemaria merged commit 9be3eab into master Sep 22, 2023
1 check passed
@jamiedemaria jamiedemaria deleted the jamie/dagster-ext-dep branch September 22, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants